python312Packages.pypass: Remove nose dependency; modernize #330222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilazy
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Result of nixpkgs-review pr 330222 run on x86_64-linux 1
6 packages built:
- pass-secret-service
- pass-secret-service.dist
- pypass (python312Packages.pypass)
- pypass.dist (python312Packages.pypass.dist)
- python311Packages.pypass
- python311Packages.pypass.dist
I’m a bit concerned about carrying a password manager that hasn’t been updated in half a decade and used random.choice to generate passwords as late as 2019, but it seems like python3Packages.pass-secret-service is semi‐actively updated and still depending on this. So, this is an improvement, thanks!
Note, though, that it looks like there’s more trouble brewing on the horizon:
pypass> /nix/store/niacps3c0qx734l2sw9fgxl5gjm365xs-python3.11-setuptools-70.0.0/lib/python3.11/site-packages/setuptools/dist.py:476: SetuptoolsDeprecationWarning: Invalid dash-separated options
pypass> !!
pypass>
pypass> ********************************************************************************
pypass> Usage of dash-separated 'description-file' will not be supported in future
pypass> versions. Please use the underscore name 'description_file' instead.
pypass>
pypass> By 2024-Sep-26, you need to update your project and remove deprecated calls
pypass> or your builds will no longer be supported.
pypass>
pypass> See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
pypass> ********************************************************************************
pypass>
pypass> !!
Comment on lines
+72
to
+74
| # Presumably this test needs the X clipboard, which we don't have | ||
| # as the test environment is non-graphical. | ||
| disabledTests = [ "test_show_clip" ]; |
There was a problem hiding this comment.
xvfb-run could come in handy here, but it’s not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.